-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sparkctl #2466
base: master
Are you sure you want to change the base?
Remove sparkctl #2466
Conversation
/hold For at least a day or two to gives others a chance to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
We've been running the Spark operator internally for ~2 years and I can say I've never used sparkctl
. We mainly interact with the the CRs with kubectl or Helm. The only functionality that comes to mind that we should add would be a way to trigger a ScheduledSparkApplication with an annotation.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jacobsalway The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There might be users who are using sparkctl considering it has been in the repo since 2018. I think it's a better idea to mark it as deprecated to give people time to deal with the removal than to remove it right away. I would mark it deprecated in Cobra and notify users in the next release notes. |
@nabuskey @jacobsalway @ChenYi015 I have raised #2484 as per the above suggestion to mark sparkctl deprecated |
Signed-off-by: Yi Chen <[email protected]>
d4abaae
to
1a8685a
Compare
New changes are detected. LGTM label has been removed. |
Since we have already mark |
I second this change/proposal. |
Purpose of this PR
Proposed changes:
Change Category
Rationale
Checklist
Additional Notes