Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sparkctl #2466

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ChenYi015
Copy link
Contributor

Purpose of this PR

Proposed changes:

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

@jacobsalway
Copy link
Member

/hold

For at least a day or two to gives others a chance to review

Copy link
Member

@jacobsalway jacobsalway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

We've been running the Spark operator internally for ~2 years and I can say I've never used sparkctl. We mainly interact with the the CRs with kubectl or Helm. The only functionality that comes to mind that we should add would be a way to trigger a ScheduledSparkApplication with an annotation.

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobsalway

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nabuskey
Copy link
Contributor

There might be users who are using sparkctl considering it has been in the repo since 2018. I think it's a better idea to mark it as deprecated to give people time to deal with the removal than to remove it right away. I would mark it deprecated in Cobra and notify users in the next release notes.

@vikas-saxena02
Copy link
Contributor

There might be users who are using sparkctl considering it has been in the repo since 2018. I think it's a better idea to mark it as deprecated to give people time to deal with the removal than to remove it right away. I would mark it deprecated in Cobra and notify users in the next release notes.

@nabuskey @jacobsalway @ChenYi015 I have raised #2484 as per the above suggestion to mark sparkctl deprecated

Signed-off-by: Yi Chen <[email protected]>
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@ChenYi015
Copy link
Contributor Author

Since we have already mark sparkctl as deprecated in v2.1.1 release notes and README, I think we can continue on removing it.

@vikas-saxena02
Copy link
Contributor

I second this change/proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove sparkctl
4 participants