-
Notifications
You must be signed in to change notification settings - Fork 275
chore: migrate from gcr.io/k8s-testimages repo #923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Address issues/921 by migrating from gcr.io/k8s-testimages to gcr.io/k8s-staging-test-infra Signed-off-by: Raymond Etornam <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: retornam The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @retornam! |
Hi @retornam. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -26,7 +26,7 @@ steps: | |||
# The image must contain bash and curl. Ideally it should also contain | |||
# the desired version of Go (currently defined in release-tools/prow.sh), | |||
# but that just speeds up the build and is not required. | |||
- name: 'gcr.io/k8s-testimages/gcb-docker-gcloud:v20240718-5ef92b5c36' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you fix the issue here: https://github.com/kubernetes-csi/csi-release-tools/blob/master/cloudbuild.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this repo just vendors that project
/ok-to-test |
Pull Request Test Coverage Report for Build 15496623209Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
@retornam: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Address issues/921 by migrating from
gcr.io/k8s-testimages to
gcr.io/k8s-staging-test-infra
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
addresses issues in #921
Which issue(s) this PR fixes:
Fixes #921
Special notes for your reviewer:
Does this PR introduce a user-facing change?: