🐛 supervisor: create ClusterModule per MachineDeployment and re-reconcile VirtualMachineResourceSetPolicy to update VirtualMachineSetResourcePolicy

[chrischdi]

What this PR does / why we need it:

• CAPV currently creates one single cluster module which is used for all machinedeployments of a cluster.
• This was added like this because there always was only a single machinedeployment used.
• This PR:
  • adds a clustermodule per machinedeployment
  • updates the clustermodule's
  • watches machinedeployments now, to trigger updates for clustermodules
  • removes the old cluster-module name used before
  • verifies that the cluster module got created by vm-operator before creating a virtual machine

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[chrischdi]

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

[chrischdi]

/hold

failed to patch VirtualMachineSetResourcePolicy clusterclass-rollout-i3y0x6/clusterclass-rollout-jxgupz:
      admission webhook "default.validating.virtualmachinesetresourcepolicy.v1alpha2.vmoperator.vmware.com"
      denied the request: spec.clustermodules: Invalid value: []string{"clusterclass-rollout-jxgupz-md-md-0-wpd29",
      "control-plane-group"}: field is immutable

[fabriziopandini]

first pass

[fabriziopandini]

Note: I prefer this approach (using the patch helper), but let's consider also using createOrUpdate for consistency with the rest of the codebase

[chrischdi]

The code did before use createOrUpdate, but only did run it on creation and never updated anything.

So I'd prefer using patch instead, especially because we may not want to always update everything (resourcePool and folder are immutable)

[fabriziopandini]

Note: when we look into v1beta2 conditions for CAPV, we should consider if/how to surface when machine creation is stuck due to corresponding module missing

[chrischdi]

It bubbles up to InfrastructureReady at the Machine:

      Message:               * VirtualMachineProvisioned: failed to create or update VirtualMachine: VirtualMachineSetResourcePolicy's .status.clusterModules does not yet contain group "quick-start-se6wwz-md-md-0-k
z75n"
      Observed Generation:   2
      Reason:                NotReady
      Status:                False
      Type:                  InfrastructureReady

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign srm09 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@chrischdi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-vsphere-apidiff-main	e205d5b	link	false	/test pull-cluster-api-provider-vsphere-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.