Skip to content

kubernetes-headlamp.yaml: Add readinessProbe to deployment #3082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

warjiang
Copy link
Contributor

@warjiang warjiang commented Apr 7, 2025

just add readinessProbe for deployment workload

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 7, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @warjiang!

It looks like this is your first PR to kubernetes-sigs/headlamp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/headlamp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 7, 2025
Copy link
Collaborator

@skoeva skoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!
Would just recommend reformatting the PR/commit title, in line with our guidelines, to something along the lines of the following:

kubernetes-headlamp.yaml: Add readinessProbe to deployment

@warjiang warjiang changed the title feat: add readinessProbe in manifest kubernetes-headlamp.yaml: Add readinessProbe to deployment Apr 8, 2025
@warjiang
Copy link
Contributor Author

warjiang commented Apr 8, 2025

Thanks for adding this! Would just recommend reformatting the PR/commit title, in line with our guidelines, to something along the lines of the following:

kubernetes-headlamp.yaml: Add readinessProbe to deployment

Thanks for the kindly suggestion, I've updated the PR title, is it still need to update the commit msg ~

@skoeva
Copy link
Collaborator

skoeva commented Apr 8, 2025

Thanks for the kindly suggestion, I've updated the PR title, is it still need to update the commit msg ~

For the commit message, you can edit it using git commit --amend and then force push to the branch (git push --force)

@warjiang
Copy link
Contributor Author

warjiang commented Apr 8, 2025

Thanks for the kindly suggestion, I've updated the PR title, is it still need to update the commit msg ~

For the commit message, you can edit it using git commit --amend and then force push to the branch (git push --force)

done~

@joaquimrocha
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joaquimrocha, skoeva, warjiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2025
@k8s-ci-robot k8s-ci-robot merged commit 6932604 into kubernetes-sigs:main Apr 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants