-
Notifications
You must be signed in to change notification settings - Fork 272
kubernetes-headlamp.yaml: Add readinessProbe to deployment #3082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @warjiang! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
Would just recommend reformatting the PR/commit title, in line with our guidelines, to something along the lines of the following:
kubernetes-headlamp.yaml: Add readinessProbe to deployment
Thanks for the kindly suggestion, I've updated the PR title, is it still need to update the commit msg ~ |
For the commit message, you can edit it using |
2afe7a9
to
1285df7
Compare
Signed-off-by: warjiang <[email protected]>
1285df7
to
0cf967d
Compare
done~ |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joaquimrocha, skoeva, warjiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
just add readinessProbe for deployment workload