Skip to content

🌱 adding jmrodri as reviewer #2707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2022
Merged

🌱 adding jmrodri as reviewer #2707

merged 2 commits into from
Jun 18, 2022

Conversation

jmrodri
Copy link
Contributor

@jmrodri jmrodri commented Jun 6, 2022 •
edited by camilamacedo86
Loading

Description

Adding myself to the reviewer's list

Motivation
Get the permissions

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 6, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @jmrodri. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jun 6, 2022
@jmrodri jmrodri changed the title Adding jmrodri as reviewer 👻 Adding jmrodri as reviewer Jun 6, 2022
@camilamacedo86 camilamacedo86 changed the title 👻 Adding jmrodri as reviewer 🌱 : Adding jmrodri as reviewer Jun 7, 2022
camilamacedo86
camilamacedo86 reviewed Jun 7, 2022
View reviewed changes
@camilamacedo86
Copy link
Member

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 7, 2022
@camilamacedo86
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 7, 2022
@camilamacedo86
Copy link
Member

/verify-owners

1 similar comment
@camilamacedo86
Copy link
Member

/verify-owners

camilamacedo86
camilamacedo86 approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approved
/lgtm

when pass in the ci check

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, jmrodri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 7, 2022
@camilamacedo86
Copy link
Member

/verify-owners

@camilamacedo86
Copy link
Member

/retest

@camilamacedo86 camilamacedo86 removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jun 15, 2022
@camilamacedo86
Copy link
Member

/verify-owners

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jun 15, 2022
@camilamacedo86 camilamacedo86 changed the title 🌱 : Adding jmrodri as reviewer 🌱 adding jmrodri as reviewer Jun 15, 2022
@k8s-ci-robot
Copy link
Contributor

@jmrodri: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubebuilder-e2e-k8s-1-21-2 102cdf8 link false /test pull-kubebuilder-e2e-k8s-1-21-2

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jmrodri
Copy link
Contributor Author

jmrodri commented Jun 18, 2022

@camilamacedo86 I submitted for access in this issue: kubernetes/org#3399 (comment) and this PR was created and shows me being added to the kubernetes-sigs org kubernetes/org#3405

https://github.com/palnabarun/org/blob/5b66d9710f73e96aa4b296d20aed9c463b4775d3/config/kubernetes-sigs/org.yaml#L347

@jmrodri
Copy link
Contributor Author

jmrodri commented Jun 18, 2022

/verify-owners

1 similar comment
@jmrodri
Copy link
Contributor Author

jmrodri commented Jun 18, 2022

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jun 18, 2022
@camilamacedo86
Copy link
Member

/test pull-kubebuilder-e2e-k8s-1-21-2

@camilamacedo86 camilamacedo86 merged commit 748e90c into kubernetes-sigs:master Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@joelanford joelanford Awaiting requested review from joelanford

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmrodri @k8s-ci-robot @camilamacedo86