Skip to content

update owners list for cluster autoscaler azure #5181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gandhipr
Copy link
Contributor

@gandhipr gandhipr commented Sep 9, 2022

Which component this PR applies to?

cluster-autoscaler

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Updates owners list in azure-cluster autoscaler

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

     NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 9, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Sep 9, 2022
@marwanad
Copy link
Member

marwanad commented Sep 9, 2022

😭 end of an era.

You can move me to emeritus_approvers list instead of removing.

Also, happy to sponsor the sig membership.

@gandhipr
Copy link
Contributor Author

gandhipr commented Sep 9, 2022 via email

@gandhipr gandhipr force-pushed the prachigandhi-azure-ca-update-owners-list branch from 647d2bd to 64194ec Compare September 9, 2022 02:53
@gandhipr
Copy link
Contributor Author

gandhipr commented Sep 9, 2022

Membership request - kubernetes/org#3668

@gandhipr
Copy link
Contributor Author

Do we have more pre-requisites before merging this PR in?

@marwanad
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gandhipr, marwanad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2022
@marwanad
Copy link
Member

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Oct 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit a395e67 into kubernetes:master Oct 13, 2022
navinjoy pushed a commit to navinjoy/autoscaler that referenced this pull request Oct 26, 2022
…a-update-owners-list

update owners list for cluster autoscaler azure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants