docs(autoscaler): add details about flags #7993
Conversation
It is currently slightly confusing if you skim through the documentation. For instance, see the discussion here: kubernetes#7974 I hope that by adding these 2 Important section the reader would be warned about the key difference, and need for these 2 options.
k8s-ci-robot
added
kind/documentation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pierreozoux The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
area/provider/cluster-api
|
Hi @pierreozoux. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
needs-ok-to-test
k8s-ci-robot
added
the
size/XS
|
@elmiko maybe this way? |
|
hey, apologies, i was out for kubecon and then pto. i need to give this some thought, will add it to my queue for this week. |
|
Thanks for your help, I did implement your recommendations. |
| @@ -79,6 +79,12 @@ in the staging namespace, belonging to the purple cluster, with the label owner= | |||
|
|
|||
| ## Connecting cluster-autoscaler to Cluster API management and workload Clusters | |||
|
|
|||
| > [!IMPORTANT] | |||
| > `--cloud-config` is the flag for specifying a mount volume path to the kubernetes configuration (ie KUBECONFIG) to the cluster-autoscaler for communicating with the cluster-api management cluster for the purpose of scaling machines. | |||
There was a problem hiding this comment.
I think we can remove "to the cluster-autoscaler" for both of these, as that relationship is already implied, I think (and it stutters following the "to the kubernetes configuration" part of the sentence).
There was a problem hiding this comment.
i was trying to be as specific as possible given the context, perhaps "for the cluster-autoscaler" ?
There was a problem hiding this comment.
ya I think that's better
It is currently slightly confusing if you skim through the documentation.
For instance, see the discussion here:
#7974
I hope that by adding these 2 Important section the reader would be warned about the key difference, and need for these 2 options.
What type of PR is this?
/kind documentation