-
Notifications
You must be signed in to change notification settings - Fork 624
[manila-csi-plugin] allow podSecurityContexts to be set in controllerplugin and nodeplugin #2759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @xrisaD! |
Hi @xrisaD. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@xrisaD thanks for your contribution. can you resolve the conflicts? |
@kayrus What should be the chart version? |
take one from the master branch and increment it |
@kayrus Is there anything else I need to do before this can be merged? Thank you! |
/ok-to-test |
@stephenfin Do you want to take a look at this? |
What this PR does / why we need it: make podSecurityContext configurable via helm for nodeplugin and controllerplugin
Which issue this PR fixes(if applicable):
fixes #2711
Special notes for reviewers:
Run
helm install manila .
Release note: