Skip to content

correct guidance for building e2e.test with debug symbols #8397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025
+3 −3
Merged

correct guidance for building e2e.test with debug symbols #8397

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
119c6d4
correct guidance for building e2e.test with debug symbols
BenTheElder Mar 25, 2025
68106d4
typo fix suggested by soltysh
BenTheElder Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions contributors/devel/sig-testing/e2e-tests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,9 +282,9 @@ For this example we'll debug a [sig-storage test that will provision storage fro
First, compile the E2E test suite with additional compiler flags

```sh
# -N Disable optimizations.
# -l Disable inlining.
make WHAT=test/e2e/e2e.test GOGCFLAGS="all=-N -l" GOLDFLAGS=""
# DBG=1 enables necessary debug options and disables stripping binaries
# see the makefile upstream, or use KUBE_VERBOSE=3 to get the actual build commands
make WHAT=test/e2e/e2e.test DBG=1
```

Then set the env var `E2E_TEST_DEBUG_TOOL=delve` and then run the test with `./hack/ginkgo.sh` instead of `kubetest`, you should see the delve command line prompt
Copy link
Member Author

@BenTheElder BenTheElder Mar 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Then set the env var `E2E_TEST_DEBUG_TOOL=delve` and then run the test with `./hack/ginkgo.sh` instead of `kubetest`, you should see the delve command line prompt
Then set the env var `E2E_TEST_DEBUG_TOOL=dlv` and then run the test with `./hack/ginkgo-e2e.sh` instead of `kubetest`, you should see the delve command line prompt
  1. dlv not delve AFAICT (the CLI != the project name)
  2. ginkgo-e2e.sh, not ginkgo.sh

That's also not enough to get it to actually work though, E2E_TEST_DEBUG_TOOL=dlv KUBERNETES_PROVIDER=skeleton ./hack/ginkgo-e2e.sh --ginkgo.focus="HTTP.proxy" fails with no output.

KUBERNETES_PROVIDER=skeleton ./hack/ginkgo-e2e.sh --ginkgo.focus="HTTP.proxy" works.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add it there?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't fully get this sorted out, patrick indicated that he's not actually using this mode and is running the binaries directly ...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, we can followup on it.

Expand Down