Skip to content

releng: Image promotion for kubernetes v1.33.0-rc.0 / v1.34.0-alpha.0 #7970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mbianchidev
Copy link
Member

Image promotion for kubernetes v1.33.0-rc.0 / v1.34.0-alpha.0
This is an automated PR generated from kpromo

kpromo pr --fork mbianchidev --tag v1.33.0-rc.0 --tag v1.34.0-alpha.0

/hold
cc: @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mbianchidev
Once this PR has been reviewed and has the lgtm label, please assign justaugustus for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 8, 2025
@jimangel
Copy link
Member

jimangel commented Apr 8, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2025
@mbianchidev
Copy link
Member Author

/unhold

I double checked the changes and this should be ok, according to the docs when the rc.0 is out we should promo the next alpha image too.

Waiting for approve and LGTM

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2025
@xmudrii
Copy link
Member

xmudrii commented Apr 8, 2025

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2025
@xmudrii
Copy link
Member

xmudrii commented Apr 8, 2025

@mbianchidev I have concerns about promoting two releases at the same time, we can barely promote one release at the same time (it pretty much always fails and we have to restart the job). Can you please create two separate PRs, and merge them one by one?

@mbianchidev
Copy link
Member Author

@mbianchidev I have concerns about promoting two releases at the same time, we can barely promote one release at the same time (it pretty much always fails and we have to restart the job). Can you please create two separate PRs, and merge them one by one?

Roger that and while I'm at it, I will also update the docs on it.

@mbianchidev mbianchidev closed this Apr 8, 2025
@mbianchidev mbianchidev deleted the kubernetes-v1.33.0-rc.0-image-promotion branch April 8, 2025 21:10
@mbianchidev
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants