-
Notifications
You must be signed in to change notification settings - Fork 879
Move from bit.ly URLs to rel.k8s.io for the release team #8109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Vyom-Yadav The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @xmudrii |
8cade56
to
2ddb574
Compare
apps/k8s-io/configmap-nginx.yaml
Outdated
if ($major = "1" && $minor <= "33") { | ||
return 301 https://bit.ly/k8s$major$minor-$remaining; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about this again, this could allow for something similar to subdomain takeover or unknown redirect.
rel.k8s.io/v123/steal-your-passwords
would redirect externally to https://bit.ly/k8s123-steal-your-passwords
which isn't safe imo. (As the user would trust rel.k8s.io)
For maintaining backwards compatibility, we can have a generic links.md in sig-release which would have the generic URLs for previous release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also constrain the lower bound if we go this route.
EDIT: To whatever version we know has all these links already to avoid squatting
I think it might be best to directly include them here without the bit.ly link in the middle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, having bit ly remains doesn't seem like a great solution. I can write a short script which can auto populate links.md for the older releases.
Updated this to do a redirect to sig-release only.
Signed-off-by: Vyom Yadav <[email protected]>
2ddb574
to
cd89e89
Compare
Bit ly has started adding ads between redirects, so we're moving away from bit ly.
Context: https://kubernetes.slack.com/archives/C2C40FMNF/p1739462854147559
/cc @BenTheElder @katcosgrove @fsmunoz @neoaggelos