Skip to content

Move from bit.ly URLs to rel.k8s.io for the release team #8109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Vyom-Yadav
Copy link
Member

Bit ly has started adding ads between redirects, so we're moving away from bit ly.

Context: https://kubernetes.slack.com/archives/C2C40FMNF/p1739462854147559

/cc @BenTheElder @katcosgrove @fsmunoz @neoaggelos

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/apps Application management, code in apps/ sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels May 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Vyom-Yadav
Once this PR has been reviewed and has the lgtm label, please assign xmudrii for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 15, 2025
@Vyom-Yadav
Copy link
Member Author

/cc @xmudrii

Comment on lines 356 to 358
if ($major = "1" && $minor <= "33") {
return 301 https://bit.ly/k8s$major$minor-$remaining;
}
Copy link
Member Author

@Vyom-Yadav Vyom-Yadav May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about this again, this could allow for something similar to subdomain takeover or unknown redirect.

rel.k8s.io/v123/steal-your-passwords would redirect externally to https://bit.ly/k8s123-steal-your-passwords which isn't safe imo. (As the user would trust rel.k8s.io)

For maintaining backwards compatibility, we can have a generic links.md in sig-release which would have the generic URLs for previous release.

Copy link
Member

@BenTheElder BenTheElder May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also constrain the lower bound if we go this route.
EDIT: To whatever version we know has all these links already to avoid squatting

I think it might be best to directly include them here without the bit.ly link in the middle?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, having bit ly remains doesn't seem like a great solution. I can write a short script which can auto populate links.md for the older releases.

Updated this to do a redirect to sig-release only.

@Vyom-Yadav Vyom-Yadav force-pushed the replace-rt-bitly-links branch from 2ddb574 to cd89e89 Compare May 24, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apps Application management, code in apps/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants