Skip to content

Remove ability to disable pagination at store level #121390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 24, 2023
Merged

Remove ability to disable pagination at store level #121390

merged 3 commits into from
Oct 24, 2023

Conversation

wojtek-t
Copy link
Member

With graduation of kubernetes/enhancements#365 to stable in #119503 pagination is always enabled.

This PR is cleaning up the code a bit to avoid no-longer-needed code

NONE

/kind cleanup
/priority important-longter
/sig api-machinery

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Oct 20, 2023
@k8s-ci-robot
Copy link
Contributor

@wojtek-t: The label(s) priority/important-longter cannot be applied, because the repository doesn't have them.

In response to this:

With graduation of kubernetes/enhancements#365 to stable in #119503 pagination is always enabled.

This PR is cleaning up the code a bit to avoid no-longer-needed code

NONE

/kind cleanup
/priority important-longter
/sig api-machinery

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 20, 2023
@wojtek-t wojtek-t changed the title Remove ability to disable pagination at store level [WIP] Remove ability to disable pagination at store level Oct 20, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 20, 2023
@wojtek-t
Copy link
Member Author

/assign @jpbetz
/cc @liggitt

@k8s-ci-robot k8s-ci-robot requested a review from liggitt October 20, 2023 13:43
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2023
@wojtek-t
Copy link
Member Author

/retest

@wojtek-t wojtek-t changed the title [WIP] Remove ability to disable pagination at store level Remove ability to disable pagination at store level Oct 20, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 20, 2023
@k8s-ci-robot k8s-ci-robot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 20, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 20, 2023
@wojtek-t
Copy link
Member Author

/retest

@dims
Copy link
Member

dims commented Oct 23, 2023

/assign @liggitt

@npolshakova npolshakova mentioned this pull request Oct 23, 2023
Closed
@liggitt
Copy link
Member

liggitt commented Oct 24, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 05f00496d49d27ed84755e2a2e2ef511148a3993

@jpbetz
Copy link
Contributor

jpbetz commented Oct 24, 2023

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, liggitt, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 722503e into kubernetes:master Oct 24, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 24, 2023
@leilajal
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 24, 2023
@p0lyn0mial p0lyn0mial mentioned this pull request Apr 11, 2024
Merged
@embik embik mentioned this pull request Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@cjcullen cjcullen Awaiting requested review from cjcullen

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@jpbetz jpbetz

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
6 participants
@wojtek-t @k8s-ci-robot @dims @liggitt @jpbetz @leilajal