-
Notifications
You must be signed in to change notification settings - Fork 14.7k
Rename _index.md to _index.html #50390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @fsehaye! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fsehaye The current change of renaming _index.md
to _index.html
doesn’t look correct as it stands. To help reviewers better understand and evaluate the changes, it would be really helpful if you could include a short description (PR description here) of the changes made and the reasoning behind it. This added context will make the contribution clearer and easier to review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/easycla
@fsehaye : Thank you for the PR. Since the CLA hasn't been signed and there's no response from your side regarding the rationale behind the change, we'll be closing it. Please feel free to reopen it, once you fulfil the aforementioned criteria. |
@divya-mohan0209: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
Issue
Closes: #