Skip to content

Rename _index.md to _index.html #50390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

fsehaye
Copy link

@fsehaye fsehaye commented Apr 4, 2025

Description

Issue

Closes: #

Copy link

CLA Not Signed

@k8s-ci-robot k8s-ci-robot requested a review from drewhagen April 4, 2025 20:51
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nate-double-u for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from tengqm April 4, 2025 20:51
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 4, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @fsehaye!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 4, 2025
Copy link

netlify bot commented Apr 4, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 35d43bc
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67f04642519d250008bf16d4
😎 Deploy Preview https://deploy-preview-50390--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fsehaye Thanks you for your contribution.
Could you please sign the CLA before the PR can be reviewed.
You can follow the steps documented here: CLA Steps

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fsehaye The current change of renaming _index.md to _index.html doesn’t look correct as it stands. To help reviewers better understand and evaluate the changes, it would be really helpful if you could include a short description (PR description here) of the changes made and the reasoning behind it. This added context will make the contribution clearer and easier to review.

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/easycla

@divya-mohan0209
Copy link
Contributor

@fsehaye : Thank you for the PR. Since the CLA hasn't been signed and there's no response from your side regarding the rationale behind the change, we'll be closing it. Please feel free to reopen it, once you fulfil the aforementioned criteria.
/close

@k8s-ci-robot
Copy link
Contributor

@divya-mohan0209: Closed this PR.

In response to this:

@fsehaye : Thank you for the PR. Since the CLA hasn't been signed and there's no response from your side regarding the rationale behind the change, we'll be closing it. Please feel free to reopen it, once you fulfil the aforementioned criteria.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants