Zero new memory after resizing ColumnChunkData #5082
Merged
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #5050; uninitialized memory ends up being used for statistics in the relationship data. I suspect there may also be an issue in
RelBatchInsert::appendNodeGroup
, since if I understand that correctly it should be filling in both the data and the gaps; so this shouldn't matter. But regardless I think the behaviour of resize should match the default behaviour of the constructor of initializing the data to zero.