Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Revert "Fix nested decimal type casting" #5199

Closed
wants to merge 1 commit into from

Conversation

mewim
Copy link
Member

@mewim mewim commented Apr 5, 2025

Reverts #5018

Copy link

github-actions bot commented Apr 5, 2025

Benchmark Result

Master commit hash: 2ea26bb3143c57783a187ea66cf2b1f809e65a6a
Branch commit hash: 19c7901ea0ce32adec1ae87c4ee5f0f2fa02fad5

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 728.84 N/A N/A
aggregation q28 6557.26 N/A N/A
filter q14 127.77 N/A N/A
filter q15 126.41 N/A N/A
filter q16 349.12 N/A N/A
filter q17 447.29 N/A N/A
filter q18 1963.26 N/A N/A
filter zonemap-node 89.50 N/A N/A
filter zonemap-node-lhs-cast 89.99 N/A N/A
filter zonemap-node-null 89.37 N/A N/A
filter zonemap-rel 5561.49 N/A N/A
fixed_size_expr_evaluator q07 680.87 N/A N/A
fixed_size_expr_evaluator q08 980.16 N/A N/A
fixed_size_expr_evaluator q09 980.87 N/A N/A
fixed_size_expr_evaluator q10 257.77 N/A N/A
fixed_size_expr_evaluator q11 259.38 N/A N/A
fixed_size_expr_evaluator q12 232.61 N/A N/A
fixed_size_expr_evaluator q13 1592.60 N/A N/A
fixed_size_seq_scan q23 110.87 N/A N/A
join q29 736.59 N/A N/A
join q30 1691.77 N/A N/A
join q31 6.99 N/A N/A
join SelectiveTwoHopJoin 47.52 N/A N/A
ldbc_snb_ic q35 10.83 N/A N/A
ldbc_snb_ic q36 100.41 N/A N/A
ldbc_snb_is q32 6.28 N/A N/A
ldbc_snb_is q33 13.65 N/A N/A
ldbc_snb_is q34 1.26 N/A N/A
multi-rel multi-rel-large-scan 1711.02 N/A N/A
multi-rel multi-rel-lookup 11.58 N/A N/A
multi-rel multi-rel-small-scan 173.71 N/A N/A
order_by q25 131.28 N/A N/A
order_by q26 441.22 N/A N/A
order_by q27 1377.52 N/A N/A
recursive_join recursive-join-bidirection 316.45 N/A N/A
recursive_join recursive-join-dense 7237.25 N/A N/A
recursive_join recursive-join-path 23720.75 N/A N/A
recursive_join recursive-join-sparse 636.85 N/A N/A
recursive_join recursive-join-trail 7065.77 N/A N/A
scan_after_filter q01 168.44 N/A N/A
scan_after_filter q02 156.22 N/A N/A
shortest_path_ldbc100 q37 93.09 N/A N/A
shortest_path_ldbc100 q38 327.00 N/A N/A
shortest_path_ldbc100 q39 57.78 N/A N/A
shortest_path_ldbc100 q40 402.88 N/A N/A
var_size_expr_evaluator q03 2125.16 N/A N/A
var_size_expr_evaluator q04 2249.67 N/A N/A
var_size_expr_evaluator q05 2763.21 N/A N/A
var_size_expr_evaluator q06 1361.00 N/A N/A
var_size_seq_scan q19 1440.57 N/A N/A
var_size_seq_scan q20 2417.79 N/A N/A
var_size_seq_scan q21 2255.47 N/A N/A
var_size_seq_scan q22 125.09 N/A N/A

Copy link

codecov bot commented Apr 5, 2025

Codecov Report

Attention: Patch coverage is 55.73770% with 27 lines in your changes missing coverage. Please review.

Project coverage is 86.94%. Comparing base (2ea26bb) to head (1542aa8).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
src/function/vector_cast_functions.cpp 55.73% 27 Missing ⚠️

❌ Your patch status has failed because the patch coverage (55.73%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5199      +/-   ##
==========================================
- Coverage   86.97%   86.94%   -0.04%     
==========================================
  Files        1405     1405              
  Lines       61622    61672      +50     
  Branches     7542     7542              
==========================================
+ Hits        53595    53619      +24     
- Misses       7853     7880      +27     
+ Partials      174      173       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@acquamarin acquamarin closed this Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants