Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use case insensitive map when binding query #5200

Merged
merged 1 commit into from
Apr 6, 2025
Merged

Conversation

andyfengHKU
Copy link
Contributor

Description

Make all variable name case insensitive in cypher statement. This behavior is more consistent with other database systems.

Fixes #3916

@andyfengHKU andyfengHKU changed the title Use case insentive map when binding query Use case insensitive map when binding query Apr 6, 2025
@andyfengHKU andyfengHKU requested a review from ray6080 April 6, 2025 13:21
Copy link

codecov bot commented Apr 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.97%. Comparing base (89d0fc7) to head (c4049aa).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5200   +/-   ##
=======================================
  Coverage   86.97%   86.97%           
=======================================
  Files        1405     1405           
  Lines       61622    61622           
  Branches     7543     7543           
=======================================
+ Hits        53594    53596    +2     
+ Misses       7854     7852    -2     
  Partials      174      174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

github-actions bot commented Apr 6, 2025

Benchmark Result

Master commit hash: 89d0fc764bcef2e70dc6fd6324b16ae7ab241f18
Branch commit hash: dc4c9d9e47f8759cc86adabed1a26af2d1d2382e

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 725.53 N/A N/A
aggregation q28 6500.19 N/A N/A
filter q14 125.86 N/A N/A
filter q15 122.60 N/A N/A
filter q16 342.42 N/A N/A
filter q17 444.76 N/A N/A
filter q18 1921.28 N/A N/A
filter zonemap-node 89.33 N/A N/A
filter zonemap-node-lhs-cast 89.15 N/A N/A
filter zonemap-node-null 89.24 N/A N/A
filter zonemap-rel 5391.98 N/A N/A
fixed_size_expr_evaluator q07 678.29 N/A N/A
fixed_size_expr_evaluator q08 961.43 N/A N/A
fixed_size_expr_evaluator q09 960.48 N/A N/A
fixed_size_expr_evaluator q10 254.09 N/A N/A
fixed_size_expr_evaluator q11 254.05 N/A N/A
fixed_size_expr_evaluator q12 232.73 N/A N/A
fixed_size_expr_evaluator q13 1565.28 N/A N/A
fixed_size_seq_scan q23 117.07 N/A N/A
join q29 758.92 N/A N/A
join q30 1613.80 N/A N/A
join q31 8.41 N/A N/A
join SelectiveTwoHopJoin 45.98 N/A N/A
ldbc_snb_ic q35 10.69 N/A N/A
ldbc_snb_ic q36 101.63 N/A N/A
ldbc_snb_is q32 6.57 N/A N/A
ldbc_snb_is q33 14.23 N/A N/A
ldbc_snb_is q34 1.31 N/A N/A
multi-rel multi-rel-large-scan 1744.84 N/A N/A
multi-rel multi-rel-lookup 8.83 N/A N/A
multi-rel multi-rel-small-scan 208.32 N/A N/A
order_by q25 126.92 N/A N/A
order_by q26 447.31 N/A N/A
order_by q27 1401.08 N/A N/A
recursive_join recursive-join-bidirection 281.95 N/A N/A
recursive_join recursive-join-dense 7117.57 N/A N/A
recursive_join recursive-join-path 23362.24 N/A N/A
recursive_join recursive-join-sparse 632.61 N/A N/A
recursive_join recursive-join-trail 7054.71 N/A N/A
scan_after_filter q01 170.41 N/A N/A
scan_after_filter q02 155.77 N/A N/A
shortest_path_ldbc100 q37 96.93 N/A N/A
shortest_path_ldbc100 q38 297.58 N/A N/A
shortest_path_ldbc100 q39 58.15 N/A N/A
shortest_path_ldbc100 q40 362.78 N/A N/A
var_size_expr_evaluator q03 2109.72 N/A N/A
var_size_expr_evaluator q04 2200.61 N/A N/A
var_size_expr_evaluator q05 2682.80 N/A N/A
var_size_expr_evaluator q06 1352.98 N/A N/A
var_size_seq_scan q19 1434.47 N/A N/A
var_size_seq_scan q20 2374.95 N/A N/A
var_size_seq_scan q21 2254.85 N/A N/A
var_size_seq_scan q22 126.38 N/A N/A

Copy link
Contributor

@ray6080 ray6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also test the case when we load from a external db source?

@andyfengHKU andyfengHKU merged commit 31c789b into master Apr 6, 2025
28 checks passed
@andyfengHKU andyfengHKU deleted the issue-3916 branch April 6, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Case-insensitive for column names with LOAD FROM
2 participants