Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript definitions for kuzu database API #5201

Merged
merged 1 commit into from
Apr 9, 2025
Merged

Conversation

mewim
Copy link
Member

@mewim mewim commented Apr 6, 2025

No description provided.

Copy link
Contributor

@andyfengHKU andyfengHKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one quick question. Do we need to add tests for this?

Copy link

codecov bot commented Apr 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.96%. Comparing base (31c789b) to head (3b73c07).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5201      +/-   ##
==========================================
- Coverage   86.97%   86.96%   -0.01%     
==========================================
  Files        1405     1405              
  Lines       61622    61622              
  Branches     7543     7543              
==========================================
- Hits        53596    53591       -5     
- Misses       7852     7857       +5     
  Partials      174      174              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

github-actions bot commented Apr 6, 2025

Benchmark Result

Master commit hash: 31c789b95a7263ba6788a5c06489332ffc0711eb
Branch commit hash: 472c7d29669fef17fc15b8dd6460ecf2b1c4ae33

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 724.74 724.37 0.37 (0.05%)
aggregation q28 6457.77 6484.13 -26.36 (-0.41%)
filter q14 126.76 125.64 1.13 (0.90%)
filter q15 125.08 126.01 -0.93 (-0.74%)
filter q16 342.22 342.83 -0.61 (-0.18%)
filter q17 444.73 445.53 -0.80 (-0.18%)
filter q18 1893.53 1897.66 -4.13 (-0.22%)
filter zonemap-node 91.65 89.76 1.88 (2.10%)
filter zonemap-node-lhs-cast 91.18 88.58 2.60 (2.93%)
filter zonemap-node-null 88.98 88.33 0.65 (0.74%)
filter zonemap-rel 5399.50 5456.31 -56.81 (-1.04%)
fixed_size_expr_evaluator q07 678.31 678.48 -0.17 (-0.02%)
fixed_size_expr_evaluator q08 962.11 962.19 -0.08 (-0.01%)
fixed_size_expr_evaluator q09 961.60 962.84 -1.24 (-0.13%)
fixed_size_expr_evaluator q10 255.16 253.65 1.51 (0.59%)
fixed_size_expr_evaluator q11 258.37 254.40 3.98 (1.56%)
fixed_size_expr_evaluator q12 237.65 233.31 4.35 (1.86%)
fixed_size_expr_evaluator q13 1561.94 1564.28 -2.33 (-0.15%)
fixed_size_seq_scan q23 114.16 111.29 2.86 (2.57%)
join q29 746.70 687.77 58.93 (8.57%)
join q30 1596.32 1574.55 21.77 (1.38%)
join q31 7.10 5.63 1.47 (26.04%)
join SelectiveTwoHopJoin 51.88 43.55 8.33 (19.12%)
ldbc_snb_ic q35 8.53 10.59 -2.05 (-19.40%)
ldbc_snb_ic q36 101.81 96.96 4.85 (5.00%)
ldbc_snb_is q32 6.47 5.49 0.98 (17.91%)
ldbc_snb_is q33 13.51 14.40 -0.89 (-6.17%)
ldbc_snb_is q34 1.14 1.29 -0.15 (-11.56%)
multi-rel multi-rel-large-scan 1692.87 1857.63 -164.76 (-8.87%)
multi-rel multi-rel-lookup 9.27 11.64 -2.37 (-20.38%)
multi-rel multi-rel-small-scan 210.89 192.47 18.43 (9.57%)
order_by q25 130.93 133.59 -2.66 (-1.99%)
order_by q26 447.83 447.43 0.39 (0.09%)
order_by q27 1385.08 1387.28 -2.21 (-0.16%)
recursive_join recursive-join-bidirection 297.21 267.38 29.82 (11.15%)
recursive_join recursive-join-dense 5718.71 7092.78 -1374.07 (-19.37%)
recursive_join recursive-join-path 23215.44 23097.45 117.99 (0.51%)
recursive_join recursive-join-sparse 630.18 633.60 -3.42 (-0.54%)
recursive_join recursive-join-trail 6370.54 7073.84 -703.30 (-9.94%)
scan_after_filter q01 169.75 169.29 0.46 (0.27%)
scan_after_filter q02 154.29 155.76 -1.48 (-0.95%)
shortest_path_ldbc100 q37 90.32 89.42 0.89 (1.00%)
shortest_path_ldbc100 q38 304.38 311.26 -6.89 (-2.21%)
shortest_path_ldbc100 q39 59.22 58.96 0.27 (0.45%)
shortest_path_ldbc100 q40 393.94 312.75 81.20 (25.96%)
var_size_expr_evaluator q03 2131.81 2115.15 16.66 (0.79%)
var_size_expr_evaluator q04 2199.97 2207.34 -7.38 (-0.33%)
var_size_expr_evaluator q05 2693.75 2683.35 10.40 (0.39%)
var_size_expr_evaluator q06 1351.05 1365.40 -14.35 (-1.05%)
var_size_seq_scan q19 1439.96 1438.12 1.84 (0.13%)
var_size_seq_scan q20 2373.92 2518.25 -144.32 (-5.73%)
var_size_seq_scan q21 2243.29 2278.71 -35.42 (-1.55%)
var_size_seq_scan q22 126.07 125.65 0.42 (0.34%)

@andyfengHKU andyfengHKU merged commit 5754568 into master Apr 9, 2025
28 checks passed
@andyfengHKU andyfengHKU deleted the typescript-def branch April 9, 2025 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants