Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix json null #5202

Merged
merged 3 commits into from
Apr 7, 2025
Merged

Fix json null #5202

merged 3 commits into from
Apr 7, 2025

Conversation

acquamarin
Copy link
Collaborator

Closes #5183
Added tests as described in the issue

Copy link

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.97%. Comparing base (31c789b) to head (2c87658).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5202      +/-   ##
==========================================
- Coverage   86.97%   86.97%   -0.01%     
==========================================
  Files        1405     1405              
  Lines       61622    61622              
  Branches     7543     7543              
==========================================
- Hits        53596    53594       -2     
- Misses       7852     7854       +2     
  Partials      174      174              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

github-actions bot commented Apr 7, 2025

Benchmark Result

Master commit hash: 3e78d1cd7be3854686796c14c6005aa79d876ba5
Branch commit hash: 6b3dc9e5a2adb6dc03b593ed1597497f551346ca

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 723.83 731.53 -7.70 (-1.05%)
aggregation q28 6554.44 6707.50 -153.06 (-2.28%)
copy node-Comment 189549.61 N/A N/A
copy node-Forum 12754.32 N/A N/A
copy node-Organisation 1205.10 N/A N/A
copy node-Person 2866.06 N/A N/A
copy node-Place 1208.11 N/A N/A
copy node-Post 81657.82 N/A N/A
copy node-Tag 1228.28 N/A N/A
copy node-Tagclass 1120.11 N/A N/A
copy rel-comment-hasCreator 134877.71 N/A N/A
copy rel-comment-hasTag 110752.57 N/A N/A
copy rel-comment-isLocatedIn 78315.39 N/A N/A
copy rel-containerOf 23715.54 N/A N/A
copy rel-forum-hasTag 5061.34 N/A N/A
copy rel-hasInterest 5881.84 N/A N/A
copy rel-hasMember 94595.88 N/A N/A
copy rel-hasModerator 1257.94 N/A N/A
copy rel-hasType 296.74 N/A N/A
copy rel-isPartOf 238.53 N/A N/A
copy rel-isSubclassOf 271.15 N/A N/A
copy rel-knows 21085.77 N/A N/A
copy rel-likes-comment 179602.08 N/A N/A
copy rel-likes-post 70895.60 N/A N/A
copy rel-organisation-isLocatedIn 337.21 N/A N/A
copy rel-person-isLocatedIn 702.96 N/A N/A
copy rel-post-hasCreator 18685.75 N/A N/A
copy rel-post-hasTag 35609.47 N/A N/A
copy rel-post-isLocatedIn 22356.64 N/A N/A
copy rel-replyOf-comment 69263.00 N/A N/A
copy rel-replyOf-post 56150.75 N/A N/A
copy rel-studyAt 737.96 N/A N/A
copy rel-workAt 1089.99 N/A N/A
filter q14 127.60 125.90 1.70 (1.35%)
filter q15 125.57 126.25 -0.68 (-0.54%)
filter q16 343.74 342.48 1.26 (0.37%)
filter q17 446.46 444.42 2.04 (0.46%)
filter q18 1910.04 2002.72 -92.68 (-4.63%)
filter zonemap-node 88.49 88.62 -0.13 (-0.14%)
filter zonemap-node-lhs-cast 89.10 88.41 0.69 (0.78%)
filter zonemap-node-null 88.97 88.11 0.86 (0.98%)
filter zonemap-rel 5313.24 5760.93 -447.69 (-7.77%)
fixed_size_expr_evaluator q07 678.37 682.51 -4.14 (-0.61%)
fixed_size_expr_evaluator q08 962.44 971.18 -8.74 (-0.90%)
fixed_size_expr_evaluator q09 960.72 967.41 -6.69 (-0.69%)
fixed_size_expr_evaluator q10 253.67 261.03 -7.36 (-2.82%)
fixed_size_expr_evaluator q11 255.89 261.81 -5.92 (-2.26%)
fixed_size_expr_evaluator q12 232.76 242.04 -9.28 (-3.83%)
fixed_size_expr_evaluator q13 1563.96 1572.46 -8.49 (-0.54%)
fixed_size_seq_scan q23 114.95 128.11 -13.16 (-10.27%)
join q29 675.49 698.01 -22.52 (-3.23%)
join q30 1631.97 1680.38 -48.42 (-2.88%)
join q31 5.77 5.45 0.32 (5.96%)
join SelectiveTwoHopJoin 52.91 52.51 0.40 (0.76%)
ldbc_snb_ic q35 10.05 8.81 1.24 (14.07%)
ldbc_snb_ic q36 107.80 95.82 11.98 (12.50%)
ldbc_snb_is q32 5.95 4.10 1.85 (45.00%)
ldbc_snb_is q33 14.58 10.39 4.19 (40.28%)
ldbc_snb_is q34 1.22 1.30 -0.08 (-6.04%)
multi-rel multi-rel-large-scan 1716.94 1704.65 12.28 (0.72%)
multi-rel multi-rel-lookup 12.67 12.10 0.57 (4.70%)
multi-rel multi-rel-small-scan 196.83 208.16 -11.33 (-5.44%)
order_by q25 127.15 133.92 -6.77 (-5.06%)
order_by q26 447.58 448.66 -1.08 (-0.24%)
order_by q27 1384.62 1407.34 -22.72 (-1.61%)
recursive_join recursive-join-bidirection 289.91 301.40 -11.50 (-3.82%)
recursive_join recursive-join-dense 5076.66 7161.86 -2085.20 (-29.12%)
recursive_join recursive-join-path 22547.64 23268.13 -720.49 (-3.10%)
recursive_join recursive-join-sparse 627.11 631.45 -4.35 (-0.69%)
recursive_join recursive-join-trail 5703.35 7060.64 -1357.29 (-19.22%)
scan_after_filter q01 171.32 171.48 -0.16 (-0.09%)
scan_after_filter q02 153.60 154.38 -0.78 (-0.51%)
shortest_path_ldbc100 q37 84.58 92.84 -8.25 (-8.89%)
shortest_path_ldbc100 q38 329.44 337.02 -7.57 (-2.25%)
shortest_path_ldbc100 q39 64.09 61.29 2.80 (4.57%)
shortest_path_ldbc100 q40 406.96 356.73 50.24 (14.08%)
var_size_expr_evaluator q03 2108.92 2100.75 8.17 (0.39%)
var_size_expr_evaluator q04 2208.31 2281.93 -73.62 (-3.23%)
var_size_expr_evaluator q05 2685.79 2737.37 -51.58 (-1.88%)
var_size_expr_evaluator q06 1356.47 1370.93 -14.46 (-1.05%)
var_size_seq_scan q19 1444.73 1438.67 6.06 (0.42%)
var_size_seq_scan q20 2280.16 2722.54 -442.38 (-16.25%)
var_size_seq_scan q21 2241.40 2295.40 -54.00 (-2.35%)
var_size_seq_scan q22 126.33 126.93 -0.60 (-0.48%)

@acquamarin acquamarin merged commit fe12d4f into master Apr 7, 2025
28 checks passed
@acquamarin acquamarin deleted the fix-json-null branch April 7, 2025 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: JSON extension returns strange errors when handling nulls
2 participants