Add more information to the fallback server #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Display the traceback, but this isn't always too helpful * Optionally pass log history for display
…ility with pydantic 2.11
julianstirling
force-pushed
the
more-fallback-info
branch
2 times, most recently
from
6798c3b to
f5c360e
Compare
Barecheck - Code coverage reportTotal: 84.08%Your code coverage diff: 2.48% ▴ Uncovered files and lines
|
julianstirling
force-pushed
the
more-fallback-info
branch
from
f5c360e to
579003c
Compare
If there is a problem on master then base_coverage will never pass meaning that coverage will never be run.
julianstirling
force-pushed
the
more-fallback-info
branch
from
579003c to
cd02d9f
Compare
julianstirling
force-pushed
the
more-fallback-info
branch
from
3f6902d to
f82f939
Compare
julianstirling
force-pushed
the
more-fallback-info
branch
from
f82f939 to
e1e630a
Compare
|
Took a while to get the pipelines to pass, due to both the base coverage erroring and also code that was tested not registering as tested. These are now fixed |
|
I've looked through the changes - I've only skimmed the test code, but this looks ready to merge to me. Thanks for sorting out the tests/CI! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more information to the fallback server:
Screenshot with OFM server passing through logs: