Fix func type 0 #97
Merged
Fix func type 0 #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 10, 2024 14:43
Include '0' as a valid function type in the dataset_58 writer.Function Type: 0 - General or Unknown
This new test validates the correct behavior of `_write58` when `func_type=0` (general or unknown data) is used. It includes dataset preparation, writing to a UFF file, reading back, and verifying both metadata and data consistency.
|
@Nuopel all looks fine. Thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #96. It allows func_type=0 in _write58 to enable general data storage as per the UFF specification. Added a test case to validate this change.