Skip to content

[WIP] Set max combination size for check-all-features to speed up CI #1717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fmoletta
Copy link
Contributor

The workflow Make sure all features work (vm) is already taking close to 50 minutes. As there is no way to partition the workflow into sets of features, this PR aims to fix this problem by setting up a max combination of features to reduce the cases to check.
Follow-up work: Investigate other workflows/ solutions that can allow us to properly partition this workflow

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.55%. Comparing base (0038711) to head (6efc0a9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1717   +/-   ##
=======================================
  Coverage   96.55%   96.55%           
=======================================
  Files         102      102           
  Lines       42872    42872           
=======================================
  Hits        41394    41394           
  Misses       1478     1478           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

github-actions bot commented Apr 16, 2024

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.132 ± 0.009 2.121 2.150 1.01 ± 0.01
head big_factorial 2.120 ± 0.007 2.108 2.132 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.055 ± 0.020 2.037 2.108 1.00 ± 0.01
head big_fibonacci 2.048 ± 0.012 2.034 2.075 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.545 ± 0.055 7.479 7.654 1.00 ± 0.01
head blake2s_integration_benchmark 7.540 ± 0.095 7.461 7.783 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.178 ± 0.018 2.151 2.214 1.00
head compare_arrays_200000 2.185 ± 0.025 2.164 2.251 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.444 ± 0.006 1.436 1.452 1.00 ± 0.01
head dict_integration_benchmark 1.441 ± 0.010 1.432 1.464 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.213 ± 0.007 1.201 1.220 1.01 ± 0.01
head field_arithmetic_get_square_benchmark 1.206 ± 0.009 1.195 1.229 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.657 ± 0.127 7.541 7.893 1.01 ± 0.02
head integration_builtins 7.563 ± 0.080 7.472 7.771 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 7.902 ± 0.104 7.773 8.052 1.01 ± 0.01
head keccak_integration_benchmark 7.802 ± 0.051 7.735 7.883 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.167 ± 0.027 2.139 2.226 1.01 ± 0.01
head linear_search 2.156 ± 0.009 2.137 2.172 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.519 ± 0.004 1.514 1.526 1.00
head math_cmp_and_pow_integration_benchmark 1.525 ± 0.008 1.514 1.535 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.483 ± 0.025 1.463 1.548 1.00 ± 0.02
head math_integration_benchmark 1.476 ± 0.004 1.470 1.482 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.218 ± 0.022 1.208 1.281 1.00 ± 0.02
head memory_integration_benchmark 1.216 ± 0.012 1.211 1.249 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.583 ± 0.013 1.573 1.612 1.00 ± 0.01
head operations_with_data_structures_benchmarks 1.582 ± 0.006 1.572 1.590 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 535.1 ± 1.6 532.9 537.8 1.00
head pedersen 535.9 ± 2.7 532.1 540.8 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 648.7 ± 1.6 646.5 651.6 1.00
head poseidon_integration_benchmark 650.5 ± 2.1 647.3 653.1 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.855 ± 0.010 1.839 1.869 1.00 ± 0.01
head secp_integration_benchmark 1.850 ± 0.003 1.846 1.855 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 663.8 ± 4.4 659.0 671.0 1.00
head set_integration_benchmark 665.2 ± 4.6 659.8 671.8 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.178 ± 0.014 4.157 4.197 1.00 ± 0.01
head uint256_integration_benchmark 4.164 ± 0.025 4.135 4.214 1.00

@fmoletta fmoletta added the pipelines This PR/issue is exclusively about improving our CI label Apr 16, 2024
Copy link

github-actions bot commented Apr 4, 2025

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     26.210 s ±  0.035 s    [User: 25.464 s, System: 0.744 s]
  Range (min … max):   26.185 s … 26.234 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     26.322 s ±  0.038 s    [User: 25.578 s, System: 0.742 s]
  Range (min … max):   26.295 s … 26.349 s    2 runs
 
Summary
  hyper_threading_main threads: 1 ran
    1.00 ± 0.00 times faster than hyper_threading_pr threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     14.553 s ±  0.054 s    [User: 25.588 s, System: 0.793 s]
  Range (min … max):   14.515 s … 14.592 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     14.610 s ±  0.075 s    [User: 25.630 s, System: 0.792 s]
  Range (min … max):   14.557 s … 14.663 s    2 runs
 
Summary
  hyper_threading_main threads: 2 ran
    1.00 ± 0.01 times faster than hyper_threading_pr threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.711 s ±  0.179 s    [User: 37.689 s, System: 0.937 s]
  Range (min … max):   10.584 s … 10.838 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.420 s ±  0.534 s    [User: 37.928 s, System: 0.952 s]
  Range (min … max):   10.042 s … 10.797 s    2 runs
 
Summary
  hyper_threading_pr threads: 4 ran
    1.03 ± 0.06 times faster than hyper_threading_main threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.440 s ±  0.211 s    [User: 37.914 s, System: 0.974 s]
  Range (min … max):   10.290 s … 10.589 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.194 s ±  0.013 s    [User: 38.202 s, System: 0.986 s]
  Range (min … max):   10.185 s … 10.203 s    2 runs
 
Summary
  hyper_threading_pr threads: 6 ran
    1.02 ± 0.02 times faster than hyper_threading_main threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.310 s ±  0.123 s    [User: 38.297 s, System: 0.946 s]
  Range (min … max):   10.223 s … 10.397 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.227 s ±  0.027 s    [User: 38.219 s, System: 0.952 s]
  Range (min … max):   10.208 s … 10.247 s    2 runs
 
Summary
  hyper_threading_pr threads: 8 ran
    1.01 ± 0.01 times faster than hyper_threading_main threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.206 s ±  0.145 s    [User: 38.701 s, System: 1.046 s]
  Range (min … max):   10.103 s … 10.308 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.357 s ±  0.175 s    [User: 38.485 s, System: 1.069 s]
  Range (min … max):   10.233 s … 10.481 s    2 runs
 
Summary
  hyper_threading_main threads: 16 ran
    1.01 ± 0.02 times faster than hyper_threading_pr threads: 16


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipelines This PR/issue is exclusively about improving our CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants