-
Notifications
You must be signed in to change notification settings - Fork 186
Migrate from pyenv to uv #1995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
edg-l
wants to merge
27
commits into
main
Choose a base branch
from
modernize_python
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Migrate from pyenv to uv #1995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The non-required ci workflow Benchmark Hyper Threading / benchmark (pull_request) fails because main doesnt use uv yet |
Benchmark Results for unmodified programs 🚀
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1995 +/- ##
=======================================
Coverage 96.65% 96.65%
=======================================
Files 103 103
Lines 43544 43544
=======================================
Hits 42089 42089
Misses 1455 1455 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FrancoGiachetta
approved these changes
Mar 11, 2025
|
FrancoGiachetta
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates the python workflow from
pyenv
to the fast modern rust baseduv
.The only takeaway is that the
pypy
versions you can install fromuv
doesn't seem to work well with thebitarray
dependency we have, as it fails to compile. Aspypy
was only used inrun_benchmarks.sh
, which was an outdated script that we no longer used, I also removed it.I also tried to update python to 3.13.2 but
cairo-run
doesnt work well, howevercairo-compile
does work well. In the end I kept the old python version 3.9.