Skip to content

fix: correct cache keys for no-std test coverage in CI #2093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: correct cache keys for no-std test coverage in CI #2093

wants to merge 2 commits into from

Conversation

crStiv
Copy link

@crStiv crStiv commented May 12, 2025 •
edited
Loading

correct cache keys for no-std test coverage in CI

Description

The fix updates the cache restoration steps in the upload-coverage job to use the correct partitioned keys (#1, #2, #3, #4) for:

  • basic no-std tests
  • no-std tests with extensive_hints
  • no-std tests with mod_builtin
  • no-std tests with cairo-0-secp-hints

Fixes #2060

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@JulianGCalderon JulianGCalderon added the pipelines This PR/issue is exclusively about improving our CI label May 12, 2025
JulianGCalderon
JulianGCalderon approved these changes May 12, 2025
View reviewed changes
Copy link
Contributor

@JulianGCalderon JulianGCalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulianGCalderon JulianGCalderon JulianGCalderon approved these changes

@FrancoGiachetta FrancoGiachetta FrancoGiachetta approved these changes

Assignees
No one assigned
Labels
pipelines This PR/issue is exclusively about improving our CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI Bug: wrong cache key for no-std test coverage
3 participants
@crStiv @JulianGCalderon @FrancoGiachetta