Add quadratic and cubic sumcheck #1003
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1003 +/- ##
==========================================
+ Coverage 72.22% 72.25% +0.02%
==========================================
Files 160 160
Lines 35340 35620 +280
==========================================
+ Hits 25525 25737 +212
- Misses 9815 9883 +68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pablodeymo
reviewed
May 15, 2025
crates/provers/sumcheck/src/lib.rs
Outdated
| if factors.is_empty() { | ||
| return Err("Cannot sum product of zero factors.".to_string()); | ||
| } | ||
| let num_total_vars = factors[0].num_vars(); |
There was a problem hiding this comment.
you can combine the previous check with this one, to void getting the element by index with []
There was a problem hiding this comment.
Thanks! Solved in ccbb7f9
|
|
||
| // Initialize Fiat-Shamir transcript | ||
| let mut transcript = DefaultTranscript::<F>::default(); | ||
| transcript.append_bytes(b"initial_sum"); |
There was a problem hiding this comment.
Transcript should also contain the number of factors and number of variables
diegokingston
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TITLE
Description
This PR improves the previous version of the sumcheck protocol allowing to support quadratic and cubic cases
Type of change
Please delete options that are not relevant.
Checklist