Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor SVG icon handling logic and optimize event listener management in embed.js to support mobile browsers #16719 #16717

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: refactor SVG icon handling logic and optimize event listener management in embed.js to support mobile browsers #16719 #16717

wants to merge 3 commits into from
+108 −57

Conversation

zwq357smile
Copy link

@zwq357smile zwq357smile commented Mar 25, 2025 •
edited by crazywoola
Loading

…gement in embed.js to support mobile browsers

Summary

Fix #16719

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@zwq357smile
fix:refactor SVG icon handling logic and optimize event listener mana…
2988bf9 
…gement in embed.js to support mobile browsers
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 💪 enhancement New feature or request labels Mar 25, 2025
@zwq357smile zwq357smile changed the title fix: refactor SVG icon handling logic and optimize event listener management in embed.js to support mobile browsers fix: Fixes #16719 refactor SVG icon handling logic and optimize event listener management in embed.js to support mobile browsers Mar 25, 2025
@zwq357smile zwq357smile changed the title fix: Fixes #16719 refactor SVG icon handling logic and optimize event listener management in embed.js to support mobile browsers fix: refactor SVG icon handling logic and optimize event listener management in embed.js to support mobile browsers #16719 Mar 25, 2025
@crazywoola crazywoola self-assigned this Mar 31, 2025
crazywoola
crazywoola requested changes Mar 31, 2025
View reviewed changes
Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image See attached image.

@zwq357smile
Copy link
Author

I'm sorry, there were some issues when synchronizing the code from the private repository to GitHub, but they have now been resolved.
微信截图_20250331141127

@zwq357smile zwq357smile requested a review from crazywoola March 31, 2025 06:17
@crazywoola
Copy link
Member

Please resolve the conflicts.

@zwq357smile
Copy link
Author

Please resolve the conflicts.

Conflicts resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RTAkland RTAkland RTAkland approved these changes

@crazywoola crazywoola Awaiting requested review from crazywoola

Requested changes must be addressed to merge this pull request.

Assignees

@crazywoola crazywoola

Labels
💪 enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Embedded small icon cannot be moved in the app, but it works on PC
3 participants
@zwq357smile @crazywoola @RTAkland