Feat: pyright helps dify remove dead var and func #16741
+148
−165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
hyongtao-db
changed the title
dosubot
bot
added
size:L
hyongtao-db
force-pushed
the
rm-dead-code
branch
from
7062c7a to
ecb3d4f
Compare
hyongtao-db
changed the title
laipz8200
requested changes
Apr 7, 2025
api/commands.py
Outdated
| @@ -561,7 +561,7 @@ def old_metadata_migration(): | |||
| for document in documents: | |||
| if document.doc_metadata: | |||
| doc_metadata = document.doc_metadata | |||
| for key, value in doc_metadata.items(): | |||
| for key, _ in doc_metadata.items(): | |||
There was a problem hiding this comment.
Suggested change
| for key, _ in doc_metadata.items(): | |
| for key in doc_metadata: |
There was a problem hiding this comment.
Done at commit 86aed5b
| @@ -122,7 +122,7 @@ def post(self): | |||
| language = "en-US" | |||
| try: | |||
| account = AccountService.get_user_through_email(args["email"]) | |||
| except AccountRegisterError as are: | |||
| except AccountRegisterError: | |||
| raise AccountInFreezeError() | |||
There was a problem hiding this comment.
Suggested change
| raise AccountInFreezeError() | |
| raise AccountInFreezeError() from are |
There was a problem hiding this comment.
Done at commit c5710e8
| @@ -153,7 +153,7 @@ def post(self): | |||
| language = "en-US" | |||
| try: | |||
| account = AccountService.get_user_through_email(args["email"]) | |||
| except AccountRegisterError as are: | |||
| except AccountRegisterError: | |||
| raise AccountInFreezeError() | |||
There was a problem hiding this comment.
Suggested change
| raise AccountInFreezeError() | |
| raise AccountInFreezeError() from are |
There was a problem hiding this comment.
Done at commit c5710e8
api/controllers/console/wraps.py
Outdated
| @@ -175,7 +175,7 @@ def decorated(*args, **kwargs): | |||
| if utm_info: | |||
| utm_info_dict: dict = json.loads(utm_info) | |||
| OperationService.record_utm(current_user.current_tenant_id, utm_info_dict) | |||
| except Exception as e: | |||
| except Exception: | |||
| pass | |||
There was a problem hiding this comment.
I think it's better to print logs here.
There was a problem hiding this comment.
Done at commit ccb4072
|
@JohnJyong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I propose to use pyright to detect unused functions and code automatically.
This is the config file
pyrightconfig.json.{ "reportUnusedVariable": "error", "reportUnusedFunction": "error", "reportUnusedClass": "error", "reportMissingImports": "none", "reportUndefinedVariable": "none", "typeCheckingMode": "off" }Tip
Close issue syntax:
Fixes #<issue number>orResolves #<issue number>, see documentation for more details.Screenshots
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods