Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add author_name for app list card #16900

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LeeeeeeM
Copy link
Contributor

@LeeeeeeM LeeeeeeM commented Mar 27, 2025

Summary

Add create_user_name for the App list card

Resolves #16898
Resolves #15250

Screenshots

Before After

|
image
|
image
|

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 💪 enhancement New feature or request labels Mar 27, 2025
@LeeeeeeM
Copy link
Contributor Author

This request is quite reasonable as it enhances search efficiency and user experience by displaying the creator's name on app cards. As for the placement of the username, it can be put in a corner or next to the title. However, we need to ensure it doesn't mess up the card's overall layout and aesthetics.

@crazywoola
Copy link
Member

I will talked to our designers about this, please wait for his feedback once I get some news.

@LeeeeeeM LeeeeeeM changed the title feat: add create_user_name for app list card feat: add author_name for app list card Mar 27, 2025
@kurokobo
Copy link
Contributor

It looks like a real tag, but is it correct to understand that it simply displays the name in the same position as the tag and does not actually function as a tag?
If that's the case, I think it's a UI that could mislead users.

@LeeeeeeM
Copy link
Contributor Author

LeeeeeeM commented Mar 28, 2025

It looks like a real tag, but is it correct to understand that it simply displays the name in the same position as the tag and does not actually function as a tag? If that's the case, I think it's a UI that could mislead users.

I also think it's not good to place it in title, the first time i would like put it in the bottom.
Just like the card in Coze.
image
But it would be covered by tags area whose position is absolute, so I bring up this issue for discussion.
And this is indeed a practical feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
3 participants