-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[Observability] Integrate OpenTelemetry #17627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazywoola
reviewed
Apr 11, 2025
TedaLIEz
commented
Apr 11, 2025
Please resolve the conflicts. |
@crazywoola Conflicts have been resolved. |
crazywoola
approved these changes
Apr 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
📚 documentation
Improvements or additions to documentation
lgtm
This PR has been approved by a maintainer
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces OpenTelemetry (OTel) support to the project, including configuration settings, initialization, and integration with various components.
OpenTelemetry Integration:
api/.env.example
: Added configuration settings for enabling and configuring OpenTelemetry.api/app_factory.py
: Includedext_otel
in the list of extensions to initialize OpenTelemetry. [1] [2]api/configs/app_config.py
: Imported and addedObservabilityConfig
to the configuration. [1] [2]api/configs/observability/__init__.py
: CreatedObservabilityConfig
class inheriting fromOTelConfig
.api/configs/observability/otel/otel_config.py
: DefinedOTelConfig
class with various OpenTelemetry configuration settings.api/extensions/ext_otel.py
: Implementedinit_app
function to initialize OpenTelemetry and set up context propagation and shutdown procedures.api/pyproject.toml
: Added OpenTelemetry dependencies.Docker Configuration:
docker/.env.example
: Added OpenTelemetry configuration settings to the Docker environment example file. [1] [2]docker/README.md
: Updated documentation to include OpenTelemetry setup instructions. [1] [2]docker/docker-compose.yaml
: Added OpenTelemetry environment variables to the shared API worker environment.By default, the opentelemetry is off. You can turn it on in
.env
Screenshots
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint gods