Update the schema stub to use iterable for the fields and filters #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs methods, enhancing type consistency and clarity. Additionally, include the Filter contract for improved functionality.
|
Thanks for the PR. I'm not sure it needs to be Do you have a specific reason for changing this? I.e. are you not returning |
|
yeah, you are right, array is a covariant of iterable. all I want to do is make PHPStan happy with the default generated schemas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the core/src/Core/Schema/Schema.php both
fieldsandfiltersreturns iterable, but stubs still generate them as arrays:abstract public function fields(): iterable;public function filters(): iterable