Skip to content

Only do extra things in official starter kits / default laravel #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

joshmanders
Copy link

Closes #410

With the addition of --using flag, we now have the ability to create userland starter kits, but unfortunately if your starter kit deviates just a little bit away from how Laravel officially does things, such as maybe the starter kit doesn't use a database at all, just a static file system, getting asked about what database you use and running commands to alter the starter based on that could be problematic. This PR only executes these prompts if you're in an official laravel starter kit or the default laravel skeleton.

@devajmeireles
Copy link

Wouldn't a better way to fix this be to check if composer.json has post-root-package-install before running it, rather than just running it on the official Laravel starter kits?

@joshmanders
Copy link
Author

Wouldn't a better way to fix this be to check if composer.json has post-root-package-install before running it, rather than just running it on the official Laravel starter kits?

It's doing more than just executing that command. Asking for a testing suite choice, copying .env.example to .env and updating the .env file could also be issues for custom starter kits.

joshmanders added a commit to composer-starters/laravel that referenced this pull request Mar 31, 2025
@taylorotwell
Copy link
Member

I think we would need to think about this one a bit. The env stuff especially feels like something you would want to keep.

@joshmanders
Copy link
Author

@taylorotwell

I think we would need to think about this one a bit. The env stuff especially feels like something you would want to keep.

That's a redundant extra step in the installer anyway as the official skeleton and all the starter kits already do that in the post-root-package-install

@joshmanders joshmanders deleted the refactor/dont-do-extra-stuff-in-starter-kits branch April 1, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--using doing too much
3 participants