Bump mimalloc #4853
Draft
Bump mimalloc #4853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, TLS trouble on macOS with mimalloc v1.8.9 (no v1.8.8 available), which they've worked on according to their changelog. |
kinke
force-pushed
the
bump_mimalloc_dlang_tools
branch
from
867d4b8 to
84c88a9
Compare
liushuyu
reviewed
May 7, 2025
packaging/mimalloc_version
Outdated
| v1.8.9 |
There was a problem hiding this comment.
Suggested change
| v1.8.9 | |
| v1.9.3 |
Maybe let's try a newer version released in March 2025 to see if the macOS situation has been resolved?
There was a problem hiding this comment.
Same problem unfortunately:
Aborting from rt/sections_elf_shared.d(200) Could not determine TLS range
What's new is a compile error for Alpine:
In file included from /__w/ldc/mimalloc/src/prim/unix/prim.c:36,
from /__w/ldc/mimalloc/src/prim/prim.c:25,
from /__w/ldc/mimalloc/src/static.c:38:
/usr/include/sys/prctl.h:88:8: error: redefinition of 'struct prctl_mm_map'
88 | struct prctl_mm_map {
| ^~~~~~~~~~~~
In file included from /__w/ldc/mimalloc/src/prim/unix/prim.c:34:
/usr/include/linux/prctl.h:134:8: note: originally defined here
134 | struct prctl_mm_map {
| ^~~~~~~~~~~~
There was a problem hiding this comment.
It seems like mimalloc breaks LDC after this mimalloc commit:
commit f126b503822addadbdfcc82f940c5a086d3f75dc (HEAD)
Author: Daan <[email protected]>
Date: Sun Oct 27 21:10:46 2024 -0700
update comments, set constructor priority to 101 on macOS
src/prim/osx/alloc-override-zone.c | 4 ++--
src/prim/prim.c | 10 +---------
2 files changed, 3 insertions(+), 11 deletions(-)
84c88a9 to
cf915da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.