Skip to content

Use git tag to tag docker image #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use git tag to tag docker image #17

wants to merge 3 commits into from
+123 −121

Conversation

rucoder
Copy link
Contributor

@rucoder rucoder commented Mar 29, 2025

Rust version is incorrectly used to tag docker image. So 1.84.1-1 is tagged as 1.84.1 and overwrote the image!
We need to re-tag 1.84.1, 1.84.1-1
Also re-tag 1.85.1 becasue 'latest' is also moved

@rucoder rucoder requested review from deitch and yash-zededa March 29, 2025 08:28
@rucoder rucoder force-pushed the rucoder/fix-docker-tag branch from 84daba0 to 3a92c62 Compare March 29, 2025 08:46
rucoder added 3 commits March 29, 2025 10:42
@rucoder
Reformat with YAML LSP
2c8e371 
Signed-off-by: Mikhail Malyshev <[email protected]>
@rucoder
Add matrix which is now required
d043ed9 
Signed-off-by: Mikhail Malyshev <[email protected]>
@rucoder
Use GIT tag as is for docker tag
3211faf 
- we should use git tag e.g. 1.84.1-1 as docker tag and not a rust
  version e.g. 1.84.1

Signed-off-by: Mikhail Malyshev <[email protected]>
@rucoder rucoder force-pushed the rucoder/fix-docker-tag branch from 3a92c62 to 3211faf Compare March 29, 2025 09:49
@rucoder
Copy link
Contributor Author

rucoder commented Apr 2, 2025

@yash-zededa could you also taker a look? I'm not sure it will work if I re-tag images

@yash-zededa
Copy link

LGTM! Just one small note on the use of set-output.

According to GitHub:

The set-output command is deprecated and will be disabled soon.

It would be better to use GITHUB_OUTPUT instead.

@yash-zededa
Copy link

@yash-zededa could you also taker a look? I'm not sure it will work if I re-tag images

Re-tag ideally should not cause an issue.

@rucoder
Copy link
Contributor Author

rucoder commented Apr 3, 2025 •
edited
Loading

@yash-zededa could you also taker a look? I'm not sure it will work if I re-tag images

Re-tag ideally should not cause an issue.

I'll do it later. it seem I need to delet git tag and put it back to trigger the action. I do not like this way but I do not see any other way to do so. @yash-zededa my concern is that the action will take the tip of main branch to build rather than the tag I set in the middle of the branch. Could you have a look at the action one more time and tell me what you think? id checkout job correct for the purpose I described?

@rucoder
Copy link
Contributor Author

rucoder commented Apr 3, 2025

LGTM! Just one small note on the use of set-output.

According to GitHub:

The set-output command is deprecated and will be disabled soon.

It would be better to use GITHUB_OUTPUT instead.

I saw this warning from GH. I'll address it in a separate PR

@rucoder
Copy link
Contributor Author

rucoder commented Apr 3, 2025

@yash-zededa could you also taker a look? I'm not sure it will work if I re-tag images

Re-tag ideally should not cause an issue.

@rucoder rucoder closed this Apr 3, 2025
@rucoder rucoder reopened this Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deitch deitch deitch approved these changes

@yash-zededa yash-zededa Awaiting requested review from yash-zededa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rucoder @yash-zededa @deitch