Skip to content

SEO optimisations including social card, landing page title and description, and relevant config changes #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

axmmisaka
Copy link
Collaborator

@axmmisaka axmmisaka commented Oct 17, 2024

This PR

  1. Created a homemade 1200x630 SVG social card for display
  2. Changed the config to use that SVG
  3. Changed standalone pages' (index, community and publication) title and description field to allow social medias to generate more informative description

Preview:
图片
图片

…iption, and relevant config changes

This commit
1. Created a homemade 1200x630 SVG social card for display
2. Changed the config to use that SVG
3. Changed standalone pages' (index, community and publication) `title` and `description` field to allow social medias to generate more informative description
@axmmisaka axmmisaka requested a review from lhstrh October 17, 2024 07:04
@lhstrh
Copy link
Member

lhstrh commented Oct 17, 2024

This is great! 🚀 What about the warning message about image size?

@axmmisaka
Copy link
Collaborator Author

This is great! 🚀 What about the warning message about image size?

idk; it's an SVG so it might cause some issue (I don't think the actual size of the canvas will be read); we could replace with a better-designed png?

@lhstrh
Copy link
Member

lhstrh commented Oct 20, 2024

studio-343b4556219b98e2c2916dcfbe94e9aa-cgh9m7cq

@lhstrh
Copy link
Member

lhstrh commented Oct 21, 2024

Not sure how to test it, but I guess it won't hurt if we just merge this...

@lhstrh lhstrh merged commit 83eccaf into lf-lang:main Oct 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants