Skip to content

Fix the new Connection.get_cursor method #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 9, 2019
Merged

Fix the new Connection.get_cursor method #82

merged 4 commits into from
Oct 9, 2019

Conversation

Changaco
Copy link
Member

@Changaco Changaco commented Oct 8, 2019 •
edited
Loading

I messed up in #73 and I forgot to update the method when I added support for subtransactions in #78. This branch fixes both of those mistakes.

@Changaco Changaco mentioned this pull request Oct 8, 2019
Merged
@Changaco Changaco force-pushed the connection.get_cursor-fix branch from cc6dd24 to f174dd7 Compare October 8, 2019 11:54
@Changaco Changaco force-pushed the connection.get_cursor-fix branch from f174dd7 to 32bc5d4 Compare October 8, 2019 11:58
@Changaco
Copy link
Member Author

Changaco commented Oct 9, 2019

The remaining issue is that with conn.cursor() as cursor and with conn.get_cursor() as cursor are now both valid but behave differently: the latter commits or rolls back at the end whereas the former only closes the cursor.

@Changaco Changaco merged commit 297f4a4 into master Oct 9, 2019
@Changaco Changaco deleted the connection.get_cursor-fix branch October 9, 2019 11:40
@Changaco Changaco mentioned this pull request Oct 9, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Changaco