Miscellaneous build script improvements #142
Merged
+12
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ethomson
commented
Feb 25, 2023
ethomson
commented
- Document the arm64 parameter that already exists
- Complain if no architecture is specified (instead of just nooping)
- Don't specify Visual Studio version; let cmake choose the version
- Don't build the tests or the CLI (so that they remain out of the resulting nuget package)
Apparently not specifying a platform means "don't do anything" which is counterintuitive. Tell people we're not going to do anything.
bording
reviewed
Feb 25, 2023
| @@ -11,6 +11,8 @@ | |||
| If set, the x64 version will be built. | |||
| .PARAMETER arm64 | |||
| If set, the arm64 version will be built. | |||
| .PARAMETER arm64 | |||
There was a problem hiding this comment.
@ethomson This is a duplicate entry. It was already there on line 12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.