Duplicate default persistent routes exist in VM after migration

[Hazanel]

Clean up duplicate persistent routes from registry during boot sequence.

[rwmjones]

The commit message should start with a single line description of the change (not "MTV-2426"), followed by a blank line, followed by a longer descrition of the change. The commit message should also have at the end Fixes: https://issues.redhat.com/browse/RHEL-89939.

Note that \\ (double backslash) appears as a single backslash in the output script, so I hope that's what you intended. If you want a double backslash in the output you have to use \\\\.

Has this been tested? How should it be tested?

There's a strange extra merge commit added, unclear what that's for.

[Hazanel]

I hope it's better now.
About testing : we should migrate the vm and use the updated virt-v2v and see in the dest vm the routing table has no duplication.
Giving you the virt-v2v command line would help?

[rwmjones]

You should be able to test this yourself. After compiling virt-v2v (see https://github.com/libguestfs/virt-v2v/blob/master/README, do not install it), run virt-v2v on a Windows disk image using:

$ ./run virt-v2v -i disk windows.img -o local -os /var/tmp --mac 52:42:00:d0:cf:0e:network:mgmt

and boot up the output VM:

$ qemu-system-x86_64 -machine accel=kvm:tcg -cpu host -m 2048 -drive file=/var/tmp/windows-sda,format=raw,if=virtio

and check it does what you expect.

I don't think we have a conversion log on the original bug yet so I don't know what exact network options were used that caused the problem, so above --mac is just a guess.