Skip to content

docs: add getting started section to examples README #5934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

VolodymyrBg
Copy link

@VolodymyrBg VolodymyrBg commented Mar 18, 2025

This PR improves the documentation in the examples/README.md file by adding proper content to the "Getting started" section that was previously empty.

Changes

  • Added instructions on how to run examples using Cargo
  • Mentioned that each example has its own README with specific instructions
  • Noted that most examples require multiple instances for P2P communication
  • Listed prerequisites for running the examples

Motivation

New users looking to try out rust-libp2p examples would benefit from clear instructions on how to get started. The empty section could be confusing and might discourage them from exploring the examples. This change makes the documentation more user-friendly and reduces the barrier to entry for people wanting to learn about libp2p.

Related Issues

N/A

Testing

No testing required as this is a documentation-only change.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Copy link
Contributor

@elenaf9 elenaf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @VolodymyrBg!

@VolodymyrBg
Copy link
Author

VolodymyrBg commented Mar 18, 2025

@elenaf9 Thanks, can it be merged, please?

Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this is yet another airdrop farming PR, specially after the demanding to be merged.

@VolodymyrBg
Copy link
Author

@jxs Hi, my pull request was approved what means it was useful as far as I understand. So I politely asked if the PR could be merged. I didn't demand to merge this PR. Sorry if something went wrong

@VolodymyrBg VolodymyrBg requested review from jxs and elenaf9 April 7, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants