Fall back if no tokio executor available #975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
twittner
reviewed
Feb 26, 2019
| // We try to use the default executor, but fall back to polling the task manually if | ||
| // no executor is available. This makes it possible to use the core in environments | ||
| // outside of tokio. | ||
| let mut executor = tokio_executor::DefaultExecutor::current(); |
There was a problem hiding this comment.
How about using the futures::future::Executor trait instead as an additional parameter type when constructing HandledNodesTasks? You could provide an implementation that loops over a set of futures or else users could plug in their own alternatives, including using a tokio executor.
There was a problem hiding this comment.
We discussed this together, and concluded that it's a change orthogonal to this PR.
twittner
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no tokio executor is available, we fall back to executing tasks directly.
This is mostly for #23