Updates antlr package to github.com/antlr4-go/antlr/v4 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also inadvertedly updates the antlr runtime to the latest version. (4.13.0)
haaawk
approved these changes
Mar 23, 2024
|
Thanks for your contribution @risico |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the tursodatabase/go-libsql#21 issue where the antl4 runtime changed their package names into a separate package.
This PR updates the package names (also inadvertently updates antlr4 runtime to the latest version, need your guys input if that's ok or not).
Once we get this merged (if) then I'll get another PR ready on go-libsql to update the package path in there as well.
Link to: https://github.com/antlr4-go/antlr
Link to why the change: https://github.com/antlr4-go/antlr?tab=readme-ov-file#why