Skip to content

Drop background processor futures feature #3777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

joostjager
Copy link
Contributor

@joostjager joostjager commented May 14, 2025

#3734 follow up to remove the futures feature

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented May 14, 2025

I've assigned @jkczyz as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@joostjager joostjager force-pushed the drop-futures-feature branch 3 times, most recently from ada9113 to 0b2524e Compare May 14, 2025 11:05
Now that we use core::future, the feature flag is no longer needed.
@joostjager joostjager force-pushed the drop-futures-feature branch from 0b2524e to 468a3c5 Compare May 14, 2025 13:44
@joostjager joostjager marked this pull request as ready for review May 14, 2025 17:26
@ldk-reviews-bot ldk-reviews-bot requested a review from jkczyz May 14, 2025 17:26
Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial, landing.

@TheBlueMatt TheBlueMatt merged commit f015545 into lightningdevkit:main May 14, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants