Async KV Store #3778
Draft
Async KV Store #3778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Async closures are complicated. Preparatory commit.
Convert methods that need to be async when the wallet traits become async.
It seems that the compiler doesn't recognize the drop and complains that the mutex crosses an await (introduced in later commit), even though it doesn't.
Async closures are complicated. Preparatory commit.
Changes the CoinSelectionSource and WalletSource traits to be async and provides WalletSourceSyncWrapper to as a helper for users that want to implement a sync wallet source. TestWalletSource is kept sync, to prevent a cascade of async conversions in tests.
|
👋 Hi! I see this is a draft PR. |
joostjager
force-pushed
the
async-kv-store
branch
from
391ffb1 to
faa071d
Compare
joostjager
commented
May 15, 2025
| Poll::Pending => { | ||
| println!("Future not ready, using tokio runtime"); | ||
|
|
||
| self.runtime.spawn(async move { |
There was a problem hiding this comment.
This doesn't need to be tokio, it could be a generic spawn method too of course.
joostjager
commented
May 15, 2025
|
|
||
| match fut.as_mut().poll(&mut cx) { | ||
| Poll::Ready(_) => { | ||
| UpdateStatus::Completed |
There was a problem hiding this comment.
This initiates the stable persistence flow in LDK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for discussion on approach
Relates to #1470