Extract non-controversion commits from Proof-system-v1 PR #1465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsTransferRoot returns true if this asset represents a root transfer. A root transfer is an asset that is neither a genesis asset nor contains split commitment witness data.
Pull Request Test Coverage Report for Build 14406448762Details
💛 - Coveralls |
Draft
|
Need to look into the failing itest... |
guggero
force-pushed
the
extract-refactors-from-proof-v1
branch
from
87a673f to
171f7ae
Compare
This bool accidentally was set to `true`. It does not affect the logic, but it does affect the debug logging in `deriveCommitmentKeys`. By correcting the value to `false`, we ensure that the debug logging mentions the correct prooftype: Exclusion.
Since we're only ever passing nil (and we use the previous witness in the script/burn key), we just remove the witness parameter completely.
guggero
force-pushed
the
extract-refactors-from-proof-v1
branch
from
171f7ae to
c8a7971
Compare
ffranr
approved these changes
Apr 17, 2025
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Taproot-Assets Project Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make review easier on #1453, I'm extracting a couple of commits that aren't directly related to that PR (or are certain we want them, like the removal of the alt leaves from the inputs).