fix: create initial credential secret before the message shows up #2226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElderMatt
requested review from
ferruhcihan,
CasLubbers,
j-zimnowoda,
merll and
Ani1357
as code owners
ferruhcihan
requested changes
Jun 12, 2025
ferruhcihan
approved these changes
Jun 13, 2025
j-zimnowoda
reviewed
Jun 16, 2025
j-zimnowoda
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
This PR creates the initial secret long before the login message shows up instead of creating it around the same time.
This makes sure that it is available when the auth is ready as well.
Also check APL-TASKS PR