Export and import feature for WebApps #348
Open
+264
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- import and export menu entry - new shortcuts for the import and the export tool - a new tool window (ei_tool.ui) - import and export handler in common.py
- remove unnecessary code and simplify it - remove the unstable profile directory export and import functionality - remove the abort function and button, as the process is so quick that they are completely unnecessary. - define gladefiles constants at the beginning of webapp-manager.py
- update text and function names - removed the ei_task class as it is no longer needed - created a get_codename() function as this is used twice in common.py - removed the tool window and the progress tracking because they are not needed - removed the browser profile export feature because it is unstable. It takes extremely long and does not work with different browser versions - implemented a function which checks during the import process whether the browser is installed on the device. If not, it searches an alternative browser on the device. - declared gladefiles paths as constants at the beginning of webapp-manager.py - removed all trailing spaces - applied the maximum line length
- bug fix: application crash It now uses GLib.idle_add() to prevent the "Segmentation fault (core dumped)" error in GTK3 - try catch in update_imported_desktop()
JW-CodeArt
force-pushed
the
feature_import_export
branch
from
58fd0d9 to
8f38735
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a graphical and user-friendly import and export feature. It exports the ".desktop" files and the custom icons to an archive, which can then be imported again. If the browser is missing, it takes the most similar alternative.
Issues related to the feature:
#292
#338
#347
#22
#232
Note: I tried to include the profiles directories, but it was unstable. For example, Firefox couldn't use a profile directory created with a newer version.
There are new menu buttons:
The new shortcuts are also documented in the shortcuts window:
After clicking the "Export" menu button, a file chooser dialog will appear:
Once the process has finished, a new dialog will appear. Users can open the containing directory directly from the dialog.
The archive contains two folders:
/applications/* with all the desktop files
/ice/icons/* with all the icons