Add support for Google's Favicon API as a fallback option #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in my issue (#349) there is a problem when trying to download Favicons for pages with redirects. Google hosts an API to reliably get the Favicon for any page by just passing in the URL.
I would suggest adding support for this API to use when fetching Favicons for a Webapp. Even though Google as a company is not quite Open-Source friendly, their API has no apparent underlying license and is used by many projects.
I believe the added reliability is worth the ideological compromise.
related to #340 and my own #349