Skip to content

Set Content-Length explicitly for http request to pumpx API #3430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 28, 2025

Conversation

BillyWooo
Copy link
Collaborator

as title. a tiny PR.
Looks like the database has set up strict rules about it.
Any idea about it? @Kailai-Wang @silva-fj

@BillyWooo BillyWooo requested review from Kailai-Wang, silva-fj and a team April 25, 2025 10:21
@BillyWooo BillyWooo self-assigned this Apr 25, 2025
Copy link
Contributor

@silva-fj silva-fj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the database has set up strict rules about it.

What do you mean? What error do you get?

@@ -113,6 +113,7 @@ impl PumpxApi {
.post(endpoint)
.header("X-Language", language.unwrap_or("en".to_string()))
.bearer_auth(access_token)
.json(&serde_json::json!({}))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this needs to be merged please put a comment here so we know that this is something required and should not be removed in the future.

@Kailai-Wang Kailai-Wang changed the title http request requires an empty body. Set Content-Length explicitly for http request to pumpx API Apr 28, 2025
@Kailai-Wang
Copy link
Collaborator

Otherwise we get 411 error

@BillyWooo BillyWooo merged commit b72be60 into dev Apr 28, 2025
19 checks passed
@BillyWooo BillyWooo deleted the bugfix_require_empty_body branch April 28, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants