ai/live: Another way to improve control channel cleanup. #3502
+6
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This achieves a similar effect as #3483 except perhaps more localized with fewer ad hoc cleanup calls - we just call cleanupLive once per session (although cleanupLive would perhaps be better named "stopControl" or thereabouts)
This allows us to ensure that orchestrator selection completes before beginning this control channel cleanup process, which mitigates any risk of ingest and control (the two primary input sources to the runner) falling out of sync due to the same cleanup function being called from various places.
Note that the gateway WHIP handler did not have this race condition because cleanup is correctly sequenced : we wait for selection to complete, wait for ingest to complete, then clean up the control channel. This PR basically introduces a similar sequencing.