Remove zero width space when getting text range for comment highlights #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajwild
force-pushed
the
zero-width-space-text-ranges
branch
from
f916972 to
b0097a8
Compare
ajwild
force-pushed
the
zero-width-space-text-ranges
branch
from
b0097a8 to
a6f34d6
Compare
ajwild
commented
Apr 20, 2025
Comment on lines
+48
to
+50
| // Do not let highlight exceed text range - it should also be at least 1 character long | ||
| const actualStartIndex = Math.min(Math.max(startIndex, 0), blockText.length - 1) | ||
| const actualEndIndex = Math.min(Math.max(endIndex, 1), blockText.length) |
There was a problem hiding this comment.
I want to take another look at this before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relations:
Motivation
When creating comments in Livingdocs it uses the selected text to create a highlight. If the text selection contains a zero width non-breaking space, which is removed when the component is blurred, then the highlight never computes the correct start and end offset for the range because the text string no longer matches.
Changelog