Skip to content

[llvm11] summary #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[llvm11] summary #16

wants to merge 1 commit into from

Conversation

dannypsnl
Copy link
Member

  • ParseSummaryIndexFlags
  • ParseBlockCount

* ParseSummaryIndexFlags
* ParseBlockCount
@dannypsnl dannypsnl requested a review from mewmew February 19, 2021 06:55
@mewmew
Copy link
Member

mewmew commented Feb 19, 2021

Hi @dannypsnl,

This PR is related to a larger issue (llir/llvm#43), the support for module summaries.

As the current grammar does not include support for module summaries (nor summary entries, SummaryEntry), the first step would be to include support for SummaryEntry before before adding specific summary entries such as summary index flags (ParseSummaryIndexFlags). The reason for this is that we need to top-level entity (SummaryEntry) to be handled by the grammar before we can add any specific summary entries.

As such, I'll put this PR on hold until support for module summaries is added, so that we can properly test it. If you would like to work on adding support for module summaries, feel free.

Cheers,
Robin

@dannypsnl
Copy link
Member Author

I see.

@dannypsnl dannypsnl closed this Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants