Type check elem in insertvalue #70
Merged
+54
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwaller
force-pushed
the
type-check-insertvalue
branch
from
2c6f31e to
c3ac8f6
Compare
Updates #67.
pwaller
force-pushed
the
type-check-insertvalue
branch
from
c3ac8f6 to
d428693
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inserting an element into an aggregate type, the type must match. Check it so that code doing this erroneously panics at the point of the mistake rather than producing ill-formed code. See discussion in #65.
Since #69 turned out to be more complicated than I first thought, I've broken out insertvalue into this PR.
Hopefully this is less complicated. I also added a simple test.
Also fixes #67.